Allow quoted file paths when redirecting with < and >#328
Merged
tleonhardt merged 1 commit intomasterfrom Mar 24, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
==========================================
+ Coverage 91% 91.01% +<.01%
==========================================
Files 1 1
Lines 1635 1636 +1
==========================================
+ Hits 1488 1489 +1
Misses 147 147
Continue to review full report at Codecov.
|
tleonhardt
approved these changes
Mar 24, 2018
Member
tleonhardt
left a comment
tleonhardt
left a comment
There was a problem hiding this comment.
@kmvanbrunt
Next time you update the CHANGELOG.md, make sure to throw in a note about this bug fix.
| """ | ||
| try: | ||
| with open(os.path.expanduser(fname[0])) as source_file: | ||
| # Any outer quotes are not part of the filename |
Member
There was a problem hiding this comment.
Nice little fix. It would be undesirable to create a file name with quotes in it.
The new behavior is much better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
< and > did not handle quoted file paths
@tleonhardt
@kotfu Make sure to handle this case in the parsing improvements you are making